Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume default priors for adstock_from_dict and saturation_from_dict functions #950

Closed
wd60622 opened this issue Aug 20, 2024 · 0 comments · Fixed by #955
Closed

Assume default priors for adstock_from_dict and saturation_from_dict functions #950

wd60622 opened this issue Aug 20, 2024 · 0 comments · Fixed by #955
Labels
good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package MMM

Comments

@wd60622
Copy link
Contributor

wd60622 commented Aug 20, 2024

These functions require the priors key in the dictionary. However, it might be convienient to assume default priors if the key is not present. This is especially useful when the user is not interested in specifying priors.

Setup:

from pymc_marketing.mmm import saturation_from_dict

Before:

saturation_from_dict({
    "lookup_name": "hill", 
    "priors": {...},
})

After

saturation_from_dict({"lookup_name": "hill"})
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package MMM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant