Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for all __init__ parameters being saved to idata.attrs #863

Closed
wd60622 opened this issue Jul 24, 2024 · 0 comments · Fixed by #867
Closed

Check for all __init__ parameters being saved to idata.attrs #863

wd60622 opened this issue Jul 24, 2024 · 0 comments · Fixed by #867
Labels
enhancement New feature or request ModelBuilder Related to the ModelBuilder class and its children

Comments

@wd60622
Copy link
Contributor

wd60622 commented Jul 24, 2024

The idata.attrs is used to reconstruct the model with save and load methods. This is a bit hard to keep the __init__, _save_input_params and load methods in sync.

Some check and test for this would be nice addition.

Potentially, the set_idata_attrs can be create_idata_attrs such that the model doesn't have to be fit in order to know if the model will not be able to saved properly.
Then the workflow in fit can be:

  • create_idata_attrs (fast and raise)
  • pm.sample (long)
  • set_idata_attrs
@wd60622 wd60622 added ModelBuilder Related to the ModelBuilder class and its children enhancement New feature or request labels Jul 24, 2024
@wd60622 wd60622 linked a pull request Jul 24, 2024 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ModelBuilder Related to the ModelBuilder class and its children
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant