Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default priors for saturation and adstock functions #723

Open
wd60622 opened this issue Jun 6, 2024 · 1 comment
Open

Default priors for saturation and adstock functions #723

wd60622 opened this issue Jun 6, 2024 · 1 comment

Comments

@wd60622
Copy link
Contributor

wd60622 commented Jun 6, 2024

Follow #632, the default priors for the new saturations might want to be looked at again. For instance, do the prior curves cover approximately the same area? Or are they all widely different?

For instance, after #722 this could be easy to compare.

saturations = [
    MichaelisMentenSaturation(), 
    LogisticSaturation(), 
    ..., 
]
ax = plt.gca()
for saturation in saturation: 
    priors = saturation.sample_prior()
    saturation.plot_curve(parameters=priors, ax=ax)
@wd60622
Copy link
Contributor Author

wd60622 commented Jun 11, 2024

For instance, the tanhbasedline defaults priors seem to not support az.hdi with its defaults arguments. This can be seen by not have a confidence band in this plot: https://www.pymc-marketing.io/en/latest/api/generated/pymc_marketing.mmm.components.saturation.TanhSaturationBaselined.html

@wd60622 wd60622 added the priors label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant