Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making optimizer pymc model agnostic #1331

Open
cetagostini opened this issue Jan 3, 2025 · 2 comments · May be fixed by #1357 or #1358
Open

Making optimizer pymc model agnostic #1331

cetagostini opened this issue Jan 3, 2025 · 2 comments · May be fixed by #1357 or #1358
Assignees
@cetagostini
Labels
enhancement New feature or request optimizer priority: high
Milestone
0.11.0

Comments

@cetagostini
Copy link
Contributor

With @ricardoV94 we were talking about make the budget optimizer model agnostic. Something like:

from pymc_marketing.mmm.budget_optimizer import BudgetOptimizer

BudgetOptimizer(
pymc_model = model,
 . . . . 
 )

Ideally, we are able to hold the current work around custom constraints and utility functions, adding this feature to be used by any pymc model.
@cetagostini cetagostini self-assigned this Jan 3, 2025
@cetagostini cetagostini added this to the 0.11.0 milestone Jan 3, 2025
@juanitorduz
Copy link
Collaborator

100%

However this feels not-trivial and probably out of scope for the 0.11 release WDYT?

@wd60622
Copy link
Contributor

wd60622 commented Jan 4, 2025

0.12.0?

@ricardoV94 ricardoV94 linked a pull request Jan 8, 2025 that will close this issue
Draft
3 tasks
@cetagostini cetagostini linked a pull request Jan 8, 2025 that will close this issue
Draft
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetagostini cetagostini

Labels
enhancement New feature or request optimizer priority: high
Projects
None yet
Milestone
0.11.0
3 participants
@juanitorduz @wd60622 @cetagostini