Put fit_result property into ModelBuilder

[wd60622]

This can be consolidated into ModelBuilder. Here it is for MMM:

pymc-marketing/pymc_marketing/mmm/base.py

Lines 292 to 297 in 10e1cbd

	@property
	def fit_result(self) -> Dataset:
	"""Get the posterior data."""
	if self.idata is None or "posterior" not in self.idata:
	raise RuntimeError("The model hasn't been fit yet, call .fit() first")
	return self.idata["posterior"]

And here it is for CLV:

pymc-marketing/pymc_marketing/clv/models/basic.py

Lines 259 to 264 in 10e1cbd

	@property
	def fit_result(self) -> Dataset:
	"""Get the fit result."""
	if self.idata is None or "posterior" not in self.idata:
	raise RuntimeError("The model hasn't been fit yet, call .fit() first")
	return self.idata["posterior"]

This can be done like here:

pymc-marketing/pymc_marketing/model_builder.py

Lines 952 to 968 in 10e1cbd

	prior = create_idata_accessor(
	"prior",
	"Call the 'sample_prior_predictive' method first.",
	)
	prior_predictive = create_idata_accessor(
	"prior_predictive",
	"Call the 'sample_prior_predictive' method first.",
	)
	posterior = create_idata_accessor("posterior", "Call the 'fit' method first.")
	posterior_predictive = create_idata_accessor(
	"posterior_predictive",
	"Call the 'sample_posterior_predictive' method first.",
	)
	predictions = create_idata_accessor(
	"predictions",
	"Call the 'sample_posterior_predictive' method with predictions=True first.",
	)

[sreekailash]

Hi @wd60622 - I can take it up since it was already a part of my earlier PR. Let me know if that is okay :D.

[sreekailash]

@wd60622 Clarification on your preference - I am planning to remove the redundant fit_result method from base.py and replace the name posterior with fit_result. Would that work or do you want me to replace fit_result with posterior everywhere? Do you have a preference?

[wd60622]

Hi @wd60622 - I can take it up since it was already a part of my earlier PR. Let me know if that is okay :D.

Thanks @sreekailash
Lets quickly get the other one through fit_result property should still stay. Dont replace with posterior despite both being available. The base class will implement for all child classes

[wd60622]

The fit_replace is still used in many places

[wd60622]

Closed with #1344