Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add posterior mean or mode or MAP curve to plot_curve_hdi #1257

Open
drbenvincent opened this issue Dec 6, 2024 · 1 comment
Open

Add posterior mean or mode or MAP curve to plot_curve_hdi #1257

drbenvincent opened this issue Dec 6, 2024 · 1 comment
Labels
enhancement New feature or request plots

Comments

@drbenvincent
Copy link
Contributor

The Transformation class has some plot methods such as:

  • plot_curve_hdi just plots the HDI
  • plot_curve plots HDI and some random samples

But it would be nice if we could allow the user to also plot a singular curve that represents out 'best guess'.

If the curve function is univariate then this is easy because we could just plot the curve for the posterior mean or median. If the curve function has multiple parameters then because the posterior could be a more complex shape than a simple bivariate normal (it could be curved), then for the curve to have meaning then we'd need to find the posterior mode.

@drbenvincent drbenvincent added enhancement New feature or request plots labels Dec 6, 2024
@wd60622
Copy link
Contributor

wd60622 commented Dec 6, 2024

If functions in pymc_marketing.mmm.plot (soon to be pymc_marketing.plot) get this change, then they will be spread everywhere they are used. Maybe an option in the plot_curve function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plots
Projects
None yet
Development

No branches or pull requests

2 participants