Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up make notebook #1141

Closed
2 tasks
wd60622 opened this issue Nov 1, 2024 · 0 comments · Fixed by #1147
Closed
2 tasks

Speed up make notebook #1141

wd60622 opened this issue Nov 1, 2024 · 0 comments · Fixed by #1147
Labels
docs Improvements or additions to documentation maintenance no releasenotes request discussion

Comments

@wd60622
Copy link
Contributor

wd60622 commented Nov 1, 2024

The test_notebook action is slow and takes about 30 minutes to run. Largely due to actual sampling of models taking place.

I few the purpose of this action is to ensure they run without errors and not that they are "correct"

The scripts/run_notebooks/runner.py script already uses Parallel with n_jobs=-1 to run the notebooks in parallel.

Some ideas to speed up this action:

I lean toward looking into mocking the pm.sample call in the notebook. We should be able to monkey patch this.

Any one else have any ideas?

@wd60622 wd60622 changed the title Speed up make notebook ideas Speed up make notebook Nov 1, 2024
@wd60622 wd60622 added docs Improvements or additions to documentation maintenance no releasenotes request discussion and removed Needs Triage labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation maintenance no releasenotes request discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant