Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The argument N is partially ignored in causalpy.data.simulate_data.generate_time_series_data #433

Open
JovanVeljanoski opened this issue Dec 20, 2024 · 0 comments

Comments

@JovanVeljanoski
Copy link

JovanVeljanoski commented Dec 20, 2024

Hi there!

I am not sure if I understand the code exactly right, but i believe that the N argment in causalpy.data.simulate_data.generate_time_series_data is being ignored.

From the docstrings I think that the N is not propagated through the function (everywhere) and in many cases 100 is hardcoded.

If I am right, I would be happy to submit a PR for this. If it is more involved, please advise.

Cheers!
(in general quite happy with this project!)

P.S.: In the same function, should the input intercept (i.e. beta_intercept) in the output dataframe instead of the constant 1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant