You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am not sure if I understand the code exactly right, but i believe that the N argment in causalpy.data.simulate_data.generate_time_series_data is being ignored.
From the docstrings I think that the N is not propagated through the function (everywhere) and in many cases 100 is hardcoded.
If I am right, I would be happy to submit a PR for this. If it is more involved, please advise.
Cheers!
(in general quite happy with this project!)
P.S.: In the same function, should the input intercept (i.e. beta_intercept) in the output dataframe instead of the constant 1 ?
The text was updated successfully, but these errors were encountered:
Hi there!
I am not sure if I understand the code exactly right, but i believe that the
N
argment incausalpy.data.simulate_data.generate_time_series_data
is being ignored.From the docstrings I think that the
N
is not propagated through the function (everywhere) and in many cases100
is hardcoded.If I am right, I would be happy to submit a PR for this. If it is more involved, please advise.
Cheers!
(in general quite happy with this project!)
P.S.: In the same function, should the input intercept (i.e.
beta_intercept
) in the output dataframe instead of the constant1
?The text was updated successfully, but these errors were encountered: