-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trace_to_dataframe in release >=3.10.0 #3907
Comments
Hi @michaelosthege, I am updating some Notebooks for Rethinking_2 and am not familiar with Arviz and PyMC development. In testing the Chp_04 code, I receive a warning that the # Code 4.32
trace_df = pm.trace_to_dataframe(trace_4_1) If I understand correctly, pymc3 3.10.0 now available on PyPI should have Many thanks. |
CC @AlexAndorra |
Hi @joannadiong, and thanks for contributing to the Rethinking notebooks! The good news is that we have a better solution ready for you to use: ArviZ's Hope this helps, and feel free to open a WIP PR on the resources repo, where we'll be able to provide guidance. |
Thanks @AlexAndorra for the helpful info! It will take me a while to digest, but should be a good learning opportunity. Richard McElreath started teaching his course again and some of us in the class are working through the ported Python code, so it seemed a good opportunity to update the notebooks. We are all new to Bayes, so some aspects of the updates will be more manageable than others. In discussing with @aloctavodia, we thought a good approach to updating the notebooks is to open an Issue for each chapter with TODO list of things to fix, then an experienced person could do all changes at once. The learners could open smaller PRs (or work-in-progress PRs) if manageable. Of course, happy to take a different approach if it works better. Hope this is cool. Many thanks for the support, and happy holidays too! |
@joannadiong This is great. I would like to encourage all students to attempt to fix those issues themselves, best way to learn! |
Seems like this was removed. |
With #3902 a DeprectationWarning is added to the
trace_to_dataframe
.As this goes into release
3.9.0
, the removal should be done with3.10.0
.The text was updated successfully, but these errors were encountered: