Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixme regression in 2.3.0.dev1 #2707

Closed
scop opened this issue Jan 27, 2019 · 1 comment
Closed

Fixme regression in 2.3.0.dev1 #2707

scop opened this issue Jan 27, 2019 · 1 comment
Assignees
Labels
Blocker 🙅 Blocks the next release Bug 🪲

Comments

@scop
Copy link
Contributor

scop commented Jan 27, 2019

Some fixme improvements from #2320 have apparently been reversed in 2.3.0.dev1 (haven't looked into details, just observing the results). Here's a test file that should not trigger any fixme W0511's:

# Todoist API: What is this task about?
# Todoist API: Look up a task's due date
# Todoist API: Look up a Project/Label/Task ID
# Todoist API: Fetch all labels
# Todoist API: "Name" value
# Todoist API: Get a task's priority
# Todoist API: Look up the Project ID a Task belongs to
# Todoist API: Fetch all Projects
# Todoist API: Fetch all Tasks
            # Todoist's time format; strptime has to be used.

pylint 2.2.2 and 2.3.0.dev0 were fine (silent), 2.3.0.dev1 triggers for all of these. (The lines are from https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/calendar/todoist.py)

@PCManticore PCManticore added Bug 🪲 Blocker 🙅 Blocks the next release labels Jan 28, 2019
@PCManticore PCManticore self-assigned this Jan 28, 2019
@PCManticore
Copy link
Contributor

Thanks @scop We recently merged a change to make fixme work only on comments, but it apparently caused some regressions. Adding it as a blocker for the next release as it's probably easy to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker 🙅 Blocks the next release Bug 🪲
Projects
None yet
Development

No branches or pull requests

2 participants