add _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR for artifact building

[greenhat616]

The new MSVC have changed the mutex behavior, and could cause the crash while VC++ runtime < 14.40.33810.0.

• related context: https://stackoverflow.com/questions/78598141/first-stdmutexlock-crashes-in-application-built-with-latest-visual-studio

For example, it was the minial repo from fastembed demo:

ONNX has fixed via their build.py: microsoft/onnxruntime#21005

I notice we have a custom CMakeList.txt to customize, and I have tried to fix it up, but failed.

• https://github.com/pykeio/ort-artifacts-staging

diff --git a/src/static-build/CMakeLists.txt b/src/static-build/CMakeLists.txt
index 1e6f474..8ac5224 100644
--- a/src/static-build/CMakeLists.txt
+++ b/src/static-build/CMakeLists.txt
@@ -5,6 +5,11 @@ set(onnxruntime_BUILD_SHARED_LIB ON)

 add_definitions(-D_SILENCE_ALL_CXX23_DEPRECATION_WARNINGS)

+if (MSVC)
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR")
+    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR")
+endif()
+
 add_subdirectory(${ONNXRUNTIME_SOURCE_DIR}/cmake onnxruntime EXCLUDE_FROM_ALL)

 function(bundle_static_library bundled_target_name)

Additionally, I tried to run sudo .\build.bat --enable_msvc_static_runtime --config Release --parallel --skip_submodule_sync in onnxrunimte project, and the result used vie ort env. The program can run as expected.

Could you do a fix for it? Thank you.

[greenhat616]

Thank you for your quick response. I verified the fix successfully through the fastembed demo and our product.

Additionally, shall we update the dist.txt in ort repo? thx.

[channing]

Hi @decahedron1, thanks for your work! Could you please also update ort-sys/dist.txt so we can use the new artifacts?

[decahedron1]

Not until the next release of ONNX Runtime, sorry.