From 81c4f1674be8a7d68a12cc398912c9e996d15347 Mon Sep 17 00:00:00 2001 From: liamhuber <liamhuber@greyhavensolutions.com> Date: Mon, 4 Dec 2023 11:15:44 -0800 Subject: [PATCH 1/5] Test on older version of OSX --- .github/workflows/unittest-mpich.yml | 2 +- .github/workflows/unittest-openmpi.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/unittest-mpich.yml b/.github/workflows/unittest-mpich.yml index d3731c4d..a9049d17 100644 --- a/.github/workflows/unittest-mpich.yml +++ b/.github/workflows/unittest-mpich.yml @@ -15,7 +15,7 @@ jobs: strategy: matrix: include: - - operating-system: macos-latest + - operating-system: macos-11 python-version: '3.11' label: osx-64-py-3-11-mpich prefix: /Users/runner/miniconda3/envs/my-env diff --git a/.github/workflows/unittest-openmpi.yml b/.github/workflows/unittest-openmpi.yml index d375e9ca..7f37d0e7 100644 --- a/.github/workflows/unittest-openmpi.yml +++ b/.github/workflows/unittest-openmpi.yml @@ -15,7 +15,7 @@ jobs: strategy: matrix: include: - - operating-system: macos-latest + - operating-system: macos-11 python-version: '3.11' label: osx-64-py-3-11-openmpi prefix: /Users/runner/miniconda3/envs/my-env From c317de0c6961a62e15626e8b826ba0dfb052e347 Mon Sep 17 00:00:00 2001 From: liamhuber <liamhuber@greyhavensolutions.com> Date: Wed, 6 Dec 2023 13:22:04 -0800 Subject: [PATCH 2/5] Add a cron test to check macos-latest --- .github/workflows/check-macos-latest.yml | 34 ++++++++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 .github/workflows/check-macos-latest.yml diff --git a/.github/workflows/check-macos-latest.yml b/.github/workflows/check-macos-latest.yml new file mode 100644 index 00000000..e55e1688 --- /dev/null +++ b/.github/workflows/check-macos-latest.yml @@ -0,0 +1,34 @@ +# We are waiting on the macos-latest image to play nicely with MPI + +name: Is-macos-latest-working-yet + +on: + schedule: + - cron: '0 23 * * 2' + +jobs: + openmpi-on-macos-latest: + runs-on: macos-latest + steps: + - uses: actions/checkout@v2 + - uses: conda-incubator/setup-miniconda@v2.2.0 + with: + python-version: "3.11" + mamba-version: "*" + channels: conda-forge + miniforge-variant: Mambaforge + channel-priority: strict + auto-update-conda: true + environment-file: .ci_support/environment-openmpi.yml + - name: Test + shell: bash -l {0} + timeout-minutes: 10 + run: | + pip install versioneer[toml]==0.29 + pip install . --no-deps --no-build-isolation + cd tests + python -m unittest discover . + env: + OMPI_MCA_plm: 'isolated' + OMPI_MCA_rmaps_base_oversubscribe: 'yes' + OMPI_MCA_btl_vader_single_copy_mechanism: 'none' From b63a782a6971c43bad7bbec5b9f38afc6a2037e6 Mon Sep 17 00:00:00 2001 From: liamhuber <liamhuber@greyhavensolutions.com> Date: Wed, 6 Dec 2023 13:23:09 -0800 Subject: [PATCH 3/5] Make it so we can run it manually --- .github/workflows/check-macos-latest.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/check-macos-latest.yml b/.github/workflows/check-macos-latest.yml index e55e1688..dc28c9d4 100644 --- a/.github/workflows/check-macos-latest.yml +++ b/.github/workflows/check-macos-latest.yml @@ -5,6 +5,7 @@ name: Is-macos-latest-working-yet on: schedule: - cron: '0 23 * * 2' + workflow_dispatch: jobs: openmpi-on-macos-latest: From 9e0af3d67cd763a5dd276a88fca66e758ee369fa Mon Sep 17 00:00:00 2001 From: liamhuber <liamhuber@greyhavensolutions.com> Date: Wed, 6 Dec 2023 13:24:53 -0800 Subject: [PATCH 4/5] Run it on the CI this once I'll remove this once the test is behaving as expected. I just can't do the manual trigger on a workflow that's only on a branch --- .github/workflows/check-macos-latest.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check-macos-latest.yml b/.github/workflows/check-macos-latest.yml index dc28c9d4..f4020eef 100644 --- a/.github/workflows/check-macos-latest.yml +++ b/.github/workflows/check-macos-latest.yml @@ -6,10 +6,11 @@ on: schedule: - cron: '0 23 * * 2' workflow_dispatch: + pull_request: jobs: openmpi-on-macos-latest: - runs-on: macos-latest + runs-on: macos-11 steps: - uses: actions/checkout@v2 - uses: conda-incubator/setup-miniconda@v2.2.0 From cbc2c2398b56087a025f74448d992778cae19e2a Mon Sep 17 00:00:00 2001 From: liamhuber <liamhuber@greyhavensolutions.com> Date: Wed, 6 Dec 2023 13:34:48 -0800 Subject: [PATCH 5/5] Test latest and not on every PR It worked just fine with the macos-11 tests, so there is nothing wrong with the workflow file. --- .github/workflows/check-macos-latest.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/check-macos-latest.yml b/.github/workflows/check-macos-latest.yml index f4020eef..dc28c9d4 100644 --- a/.github/workflows/check-macos-latest.yml +++ b/.github/workflows/check-macos-latest.yml @@ -6,11 +6,10 @@ on: schedule: - cron: '0 23 * * 2' workflow_dispatch: - pull_request: jobs: openmpi-on-macos-latest: - runs-on: macos-11 + runs-on: macos-latest steps: - uses: actions/checkout@v2 - uses: conda-incubator/setup-miniconda@v2.2.0