Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot update workflow might use wrong files?! #55

Closed
niklassiemer opened this issue Nov 6, 2023 · 1 comment · Fixed by #56
Closed

Dependabot update workflow might use wrong files?! #55

niklassiemer opened this issue Nov 6, 2023 · 1 comment · Fixed by #56

Comments

@niklassiemer
Copy link
Member

While the positions of the env and mapping file are fixed here

environment_file = sys.argv[7]
name_mapping_file = sys.argv[8]

They seem to be different for changed depandabot PR titles if I look at

def pattern_is_bump_from_to(list_):
if len(list_) != 9:
return False
return all(
[
list_[1] == 'Bump',
list_[3] == 'from',
list_[5] == 'to',
ends_in_yml(list_[7])
]
)
def pattern_is_update_requirement_from_to(list_):
if len(list_) != 10:
return False
return all(
[
list_[1] == 'Update',
list_[3] == 'requirement',
list_[4] == 'from',
list_[6] == 'to',
ends_in_yml(list_[8])
]
)

@liamhuber
Copy link
Member

Yyyyyep. I think we got away with it because all of the PRs have been in "bump" format for so long so the error in "update" format just never came up.

@niklassiemer niklassiemer linked a pull request Nov 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants