-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show useful warning when there is no wgpu-native binary #298
Comments
Although rare, I remember you originally presenting this as a feature. But maybe in hindsight it never applies when people install from pip... |
It would also be installed on python versions that aren't covered by the available binaries, e.g.
This could be nice, but I think it would get swamped by the log since it would be installed alongside other dependencies that downstream has. I fear that users would simply miss this, run a program, see that it breaks, and then maybe come back to the install log (if they even bothered to store it). A runtime warning/error sounds like an excellent idea though; however, I think we already have that since the library raises an exception if the binary is not present 😄
A question to ask is if we can reasonably expect the binary to be present at install/setup time. If so, we could simply check that (while respecting Another thought would be to ask users who want a source install to use
Doesn't pypi keep download statistics of the different versions? I don't know how granular they are, but I would not be surprised to find that we can go and check how often the source distribution is actually downloaded. |
Yeah, but I mean it could be improved to e.g. show a tip to update pip.
Interesting! So only wheels on pypi, and if you had a successful install with pip, it should just work. Let's explore scenario's:
I think it will improve the installation flow for most users. However, I think that last person might have a strong opinion about us not putting the source dist on Pypi :) @Korijn thoughts?
I don't see any stats in the Pypi management UI. |
That data lives on Google BigQuery and pypi documents this here. I just checked and you can indeed get the information on which file was downloaded when. Here is a sample record of me from yesterday downloading the source distribution of wgpu on WSL (lol, found it by chance).
Here is a quick pivot of this month's downloads by file type (columns) and installer (rows). Note that I would run this for the past quarter and/or year so that we can make a more informed decision, but I am out of free quota for this month already 😅 (it's a big table ... the 1TB quota feels like a drop in the bucket) |
Now that I've seen #331 I would say you just need to add another case to the same function and we could close this issue:
|
With an older pip, the src distribution would be installed, which does not contain wgpu-native. Would be nice to warn about this.
Note that in rare situations the sdist could be installed intentionally, with the user providing the wgpu-native binary.
The text was updated successfully, but these errors were encountered: