Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in the implementation of sagpool #9862

Open
ChenYizhu97 opened this issue Dec 14, 2024 · 0 comments
Open

Bug in the implementation of sagpool #9862

ChenYizhu97 opened this issue Dec 14, 2024 · 0 comments
Labels

Comments

@ChenYizhu97
Copy link

🐛 Describe the bug

Hi this is an old bug described in pull request #8562 .

As mentioned, the implementation of select function in sagpool reuses the select class of topkpool, which introduces an extra learnable weight. As a consequence, this select function learns to take the opposite of the scores if the weight is negative, which is not consistent with the paper, neither the codes of the authors. In my observation, this change influences the effectiveness of sagpool significantly in some situations.

Considering the future work may use the sagpool layer in Pyg for evaluation, would you mind fixing this bug so that it doesn't influence their results and conclusion?

Versions

I cant get the collect_env tool. The connection refused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant