Allow for set and other unsubscriptable data structures. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…), thanks to @konstantin-lebejko
|
Some tests are still failing here on my machine and I'm not sure whether this is due to my environment, whether my change has has an unintended consequence, or whether an update to some other library is causing an issue in the tests. Is there CI or anything similar this can be run through to get a clear view on this? |
kodurusivakumar34
approved these changes
Jun 22, 2023
|
can you someone try to merge this fix? |
|
@craiga can you please try to merge this pull request |
|
@kodurusivakumar34 I don't have write permissions here, that'd be a job for @chfw I believe. |
|
@chfw can you please review and merge this PR |
|
What's the status on this merge? |
kzadm
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #52
With your PR, here is a check list:
make formatbeen run?