Add maxlength minlength examples #509
Conversation
| @@ -444,7 +444,8 @@ The assigned data can be of any type. | |||
| min, max | |||
| -------- | |||
|
|
|||
| Minimum and maximum value allowed for any types that implement comparison operators. | |||
| Minimum and maximum value allowed for any types that implement comparison operators. See | |||
There was a problem hiding this comment.
proposal: "… implement the corresponding comparison method (__lt__ or __gt__)."
i think a concrete, simple example here would be better than the more complex ones that a referred.
There was a problem hiding this comment.
The proposal seems fine, but not sure what are (__lt__ or __gt__), I can just add them if you want. I just felt that by comparison operators we are going for \*of-rules
Roger that, a simple example coming right up.
There was a problem hiding this comment.
these "dunder" (from double underscore) or also known as "magic" methods do implement these operations that the operators imply. so, maybe just "comparison operations" instead of "operator"?
There was a problem hiding this comment.
Thanks, @funkyfuture for the explanation.
docs/validation-rules.rst
Outdated
| @@ -457,6 +458,22 @@ minlength, maxlength | |||
|
|
|||
| Minimum and maximum length allowed for iterables. | |||
There was a problem hiding this comment.
on that occassion you could correct one of my mistakes: "iterables" is false in that sentence. truth is that any object that implements __len__ works with this rule. the abstract class is collections.abc.Sized, but i don't think the term "sized" is established and clear.
There was a problem hiding this comment.
True that in my project to we had a bit of trouble with collections as we were trying to validate Cerberus Schema and on first thought I just went to validate if the schema is a dict or not. But, later after digging into Mapping and Cerberus's source code that I realized that any Mapping type can be validated. That's a bit of back story I thought I add to the discussion.
Coming back to it, I have changed it now let me know if this works.
|
also, could you please change your branch to base on the |
Signed-off-by: Vipul Gupta (@vipulgupta2048) <[email protected]>
vipulgupta2048
force-pushed
the
add-examples-docs
branch
from
62f6aa9 to
03be019
Compare
Signed-off-by: Vipul Gupta (@vipulgupta2048) <[email protected]>
|
Hey @funkyfuture, I guess it's a first time for everything. I have changed the base branch (First time) and implemented the changes. Let me know how you feel about them. |
|
thanks, merged with 0fccd9b |
🐣
Added missing examples for
maxlengthandminlengthvalidation rules to the docs in accordance with #500, let me know if there are any more examples that you like to see. Or improve any examples. Would be happy to write and contribute to the docs.Signed-off-by: Vipul Gupta (@vipulgupta2048) [email protected]