Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saved games directory discovery is incorrect #148

Open
2 tasks
DanAlbert opened this issue May 25, 2021 · 0 comments
Open
2 tasks

saved games directory discovery is incorrect #148

DanAlbert opened this issue May 25, 2021 · 0 comments

Comments

@DanAlbert
Copy link
Collaborator

(not urgent for us, just filing so folks are aware of it)

dcs-liberation/dcs_liberation#1116

dcs.installation.get_dcs_saved_games_directory has two problems:

  • The DCS.openbeta is not tried (idk how to determine which should be used; I think standalone uses it but steam doesn't?)
  • ~/Saved Games will not resolve to the correct location for users that have moved their Saved Games directory

In case anyone is confused by the second one like I was, Windows does allow you to relocate "shell folders" like Saved Games: shell folder relocation dialog

https://docs.microsoft.com/en-us/windows/win32/shell/knownfolderid would be a starting place for fixing the second issue. There doesn't appear to be a python API for this (though there are libraries on pypi), but it should be fairly easy to use via ctypes.windll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant