Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FutureWarning for pandas date_range #6985

Closed
headtr1ck opened this issue Sep 4, 2022 · 1 comment · Fixed by #7373
Closed

FutureWarning for pandas date_range #6985

headtr1ck opened this issue Sep 4, 2022 · 1 comment · Fixed by #7373
Labels
API design topic-pandas-like

Comments

@headtr1ck
Copy link
Collaborator

What is your issue?

Xarray raises a FutureWarning in its date_range, also observable in your tests.
The precise warning is:

xarray/coding/cftime_offsets.py:1130: FutureWarning: Argument closed is deprecated in favor of inclusive.

You should discuss if you will adapt the new inclusive argument or add a workaround.
@headtr1ck headtr1ck added the needs triage Issue that has not been reviewed by xarray team member label Sep 4, 2022
@mathause mathause added API design topic-pandas-like and removed needs triage Issue that has not been reviewed by xarray team member labels Sep 5, 2022
@headtr1ck headtr1ck mentioned this issue Nov 12, 2022
Closed
@spencerkclark
Copy link
Member

Thanks for pinging this issue again in #7266 -- apologies for missing it earlier. I think we should adapt to the new inclusive argument and implement it for the cftime_range function as well.

@spencerkclark spencerkclark mentioned this issue Dec 10, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API design topic-pandas-like
Projects
None yet
Milestone
No milestone
3 participants
@spencerkclark @mathause @headtr1ck