Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eval? #6440

Closed
max-sixty opened this issue Apr 5, 2022 · 2 comments · Fixed by #7163
Closed

Add eval? #6440

max-sixty opened this issue Apr 5, 2022 · 2 comments · Fixed by #7163

Comments

@max-sixty
Copy link
Collaborator

Is your feature request related to a problem?

We currently have query, which can runs a numexpr string using eval.

Describe the solution you'd like

Should we add an eval method itself? I find that when building something for the command line, allowing people to pass an eval-able expression can be a good interface.

Describe alternatives you've considered

No response

Additional context

No response

@relativistic
Copy link

This was labeled as completed with #7163 , but if I'm reading the documentation correctly, Dataset.eval does not allow the numexpr engine, like the original comment by @max-sixty requests. Any idea if there is any plan to enable the numexpr engine like in the original comment

I am doing math operations on very large dataarrays, and am trying to find ways to avoid making lots of copies of the data. numexpr seems like it is smarter about this than a python engine would be.

@max-sixty
Copy link
Collaborator Author

Any idea if there is any plan to enable the numexpr engine like in the original comment

I don't think anyone is working on it. But we'd be very open to a contribution...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants