Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Nightly upstream-dev CI failed ⚠️ #5919

Closed
github-actions bot opened this issue Oct 30, 2021 · 2 comments
Closed

⚠️ Nightly upstream-dev CI failed ⚠️ #5919

github-actions bot opened this issue Oct 30, 2021 · 2 comments
Labels
CI Continuous Integration tools topic-testing upstream issue

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2021

Workflow Run URL

Python 3.9 Test Summary Info
FAILED xarray/tests/test_variable.py::TestVariable::test_pandas_period_index
FAILED xarray/tests/test_variable.py::TestVariableWithDask::test_pandas_period_index
FAILED xarray/tests/test_variable.py::TestIndexVariable::test_pandas_period_index
@github-actions github-actions bot added the CI Continuous Integration tools label Oct 30, 2021
@keewis keewis mentioned this issue Nov 1, 2021
@mathause
Copy link
Collaborator

mathause commented Nov 1, 2021

The test failures can be reproduced with:

import pandas as pd
import numpy as np
np.array(0) == pd.Period("2000", freq="B")

This returns False in pandas 1.3.4 but raises TypeError: iteration over a 0-d array in pandas master. I think the culprit is pandas-dev/pandas#44182 which added a code path for numpy arrays in Period.__richcmp__.

The failure happens in

assert v[0] == pd.Period("2000", freq="B")

and we could fix it with

-        assert v[0] == pd.Period("2000", freq="B")
+        assert v[0:1] == pd.Period("2000", freq="B")

@mathause
Copy link
Collaborator

mathause commented Nov 2, 2021

Should get fixed upstream: pandas-dev/pandas#44285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tools topic-testing upstream issue
Projects
None yet
Development

No branches or pull requests

2 participants