Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in xarray/doc/examples/monthly-means.rst line 86 ? #3465

Closed
mickaellalande opened this issue Oct 30, 2019 · 0 comments
Closed

Error in xarray/doc/examples/monthly-means.rst line 86 ? #3465

mickaellalande opened this issue Oct 30, 2019 · 0 comments

Comments

@mickaellalande
Copy link
Contributor

I have made a pull request (Error in leap year? #3464) but I don't know how it works.
I guess there is a mistake in xarray/doc/examples/monthly-means.rst line 86 :

I've tried this script; however, it adds +1 to all months of the leap years. It sounds like an error, or I am wrong? So I wrote the condition "and month == 2" line 86 so that only the month of February gets +1.

So I propose :

if leap_year(year, calendar=calendar) and month == 2:

Instead of:

if leap_year(year, calendar=calendar):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants