Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GRIB data as an example dataset #3118

Closed
zbruick opened this issue Jul 13, 2019 · 4 comments
Closed

Allow GRIB data as an example dataset #3118

zbruick opened this issue Jul 13, 2019 · 4 comments

Comments

@zbruick
Copy link

zbruick commented Jul 13, 2019

Need to add support for other files than netCDF in load_dataset, namely for GRIB data, which a PR will be coming to fix shortly.

@zbruick
Copy link
Author

zbruick commented Jul 13, 2019

And I would think support for .zarr and .hdf files may also be useful at some point down the road. While there are many ugly ways to do this, the cleanest way that @StephanSiemen and myself have thought of is to make load_dataset as general as possible, which would break the current examples by requiring the full file name, including the extension in load_dataset. Thoughts on this? @rabernat

@rabernat
Copy link
Contributor

I know how to do this and will soon submit a PR to fix it.

@rabernat
Copy link
Contributor

make load_dataset as general as possible, which would break the current examples by requiring the full file name, including the extension in load_dataset

The solution is to check whether name has an extension or not. If no extension, then we append .nc.

@dcherian
Copy link
Contributor

Closed by #3121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants