Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append to zarr redundant with mode='a' #3100

Closed
davidbrochart opened this issue Jul 12, 2019 · 3 comments · Fixed by #3123
Closed

Append to zarr redundant with mode='a' #3100

davidbrochart opened this issue Jul 12, 2019 · 3 comments · Fixed by #3123
Labels
topic-zarr Related to zarr storage library

Comments

@davidbrochart
Copy link
Contributor

When appending to a zarr store, we need to set append_dim=dim_name but also mode='a'. Any reason to also specify the writing mode? I think it should automatically be set to 'a' if append_dim is not None.
@dcherian dcherian added the topic-zarr Related to zarr storage library label Jul 12, 2019
@shoyer
Copy link
Member

shoyer commented Jul 14, 2019

This sounds reasonable to me.

@davidbrochart davidbrochart mentioned this issue Jul 14, 2019
Merged
3 tasks
@davidbrochart
Copy link
Contributor Author

@shikharsg, @jendrikjoe and @rabernat might be interested too.

@shikharsg
Copy link

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-zarr Related to zarr storage library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

to_zarr(append_dim='dim0') doesn't need mode='a' davidbrochart/xarray
4 participants
@shoyer @dcherian @davidbrochart @shikharsg