Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark slow tests and don't run them by default #1309

Closed
shoyer opened this issue Mar 14, 2017 · 2 comments
Closed

Mark slow tests and don't run them by default #1309

shoyer opened this issue Mar 14, 2017 · 2 comments

Comments

@shoyer
Copy link
Member

shoyer commented Mar 14, 2017

We'll have a few more of these after #1198 goes in, but plotting and some of the rolling aggregation tests already fall in this category.

For development purposes, it would be nice if these don't run automatically so the whole test suite can finish in handful of seconds. They should still always run on Travis-CI and Appveyor, which take a few minutes to setup.

See
http://doc.pytest.org/en/latest/example/simple.html#control-skipping-of-tests-according-to-command-line-option for guidance from pytest.

@pwolfram
Copy link
Contributor

@shoyer, this seems pretty straight forward from http://doc.pytest.org/en/latest/example/simple.html#control-skipping-of-tests-according-to-command-line-option-- all we need is to define the @slow decorator and mark the slow tests, correct? This seems like a fast PR write-up / fulfill following merge of #1198 unless I'm missing something.

@max-sixty
Copy link
Collaborator

I would have a preference for py.test --skip-slow to explicitly skip, rather than default skipping.

And then unit tests should be fast, this is only for tests that really can't be made fast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants