Setting default_mode to dark does not work because it is overwritten by the inline script

[char101]

Hi,

In

pydata-sphinx-theme/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html

Line 17 in a135c20

document.documentElement.dataset.theme = localStorage.getItem("theme") || "light";

I think light should be {{ default_mode }}, because it adds data-theme="light" attribute to the html tag which overrides the data-mode="dark" attribute.

In my case, I added html_context = {"default_mode": "dark"} to conf.py. In the static source, data-mode="dark" is added to the html tag, but the theme is still light. In the developer tools, a new data-theme="light" is added to the html tag where the cause is above inline script.

[12rambau]

nice catch, would you be willing to make a PR ?

[char101]

Created a pull request via the web editor

#1663