Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top bar disappears when scrolling down #1627

Closed
dbitouze opened this issue Jan 4, 2024 · 2 comments · Fixed by #1630
Closed

Top bar disappears when scrolling down #1627

dbitouze opened this issue Jan 4, 2024 · 2 comments · Fixed by #1630
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship kind: bug Something isn't working tag: CSS CSS and SCSS related issues

Comments

@dbitouze
Copy link
Contributor

dbitouze commented Jan 4, 2024

With PST 0.15.1, the top bar disappears when scrolling down:

image
@dbitouze dbitouze mentioned this issue Jan 4, 2024
Closed
@12rambau 12rambau added kind: bug Something isn't working tag: CSS CSS and SCSS related issues impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship labels Jan 4, 2024
@drammock
Copy link
Collaborator

drammock commented Jan 4, 2024

This is related to https://github.com/pydata/pydata-sphinx-theme/pull/1454/files#diff-c8b78528cfd92c0b193eee9d4af6b8115fdcce4f665ca20c855fbe5334078865 where <header> tag was removed from the top navbar. cc @gabalafou

@gabalafou
Copy link
Collaborator

Hmm. Looking into this now.

@gabalafou gabalafou mentioned this issue Jan 4, 2024
Merged
@drammock drammock mentioned this issue Jan 15, 2024
Closed
@Charlie-XIAO Charlie-XIAO mentioned this issue Jan 16, 2024
Closed
26 tasks
@drammock drammock mentioned this issue Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship kind: bug Something isn't working tag: CSS CSS and SCSS related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sticky header gabalafou/pydata-sphinx-theme
4 participants
@gabalafou @dbitouze @drammock @12rambau