Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: TOC links jump to section with some offset #147

Closed
jorisvandenbossche opened this issue Apr 9, 2020 · 2 comments · Fixed by #174
Closed

BUG: TOC links jump to section with some offset #147

jorisvandenbossche opened this issue Apr 9, 2020 · 2 comments · Fixed by #174

Comments

@jorisvandenbossche
Copy link
Member

For example check this link: https://pydata-sphinx-theme.readthedocs.io/en/latest/demo/example_pandas.html#selection-by-label (or click on any of the links in the right sidebar TOC), and the title of is partly below the top bar.

I know we previously added some offset for that somewhere in the css. But that might have gotten accidentally changed in the recent css refactorings.

cc @hoetmaaiers

@jorisvandenbossche
Copy link
Member Author

I checked an old version, and this was in the css I suppose for that:

https://github.com/pandas-dev/pydata-sphinx-theme/blob/937ab82e8ba44802ce1b25f8a2fc352db57e1156/pandas_sphinx_theme/static/css/custom.css#L211-L224

(not sure if that was the best way to solve it though ;-))

@hoetmaaiers
Copy link
Collaborator

hoetmaaiers commented Apr 9, 2020

I checked an old version, and this was in the css I suppose for that:

https://github.com/pandas-dev/pydata-sphinx-theme/blob/937ab82e8ba44802ce1b25f8a2fc352db57e1156/pandas_sphinx_theme/static/css/custom.css#L211-L224

(not sure if that was the best way to solve it though ;-))

Hi Joris, certainly not a bad way of solving this. I also brought this part of the code back after losing It during refactor. Not sure where it goes wrong now. I will look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants