-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed Design Update for Focus State - Links #1397
Comments
I don't have any specific competence in accessibility design so this is just me thinking out loud. |
I am in favour of 1 too: it is the right balance between being noticeable and not too on your face or distracting |
I also endorse option 1. Sounds like we're unanimous: full speed ahead! |
Nice one team. |
Completed via #1564 |
TL;DR:
This issue proposes a new design for the focus state of links, aiming to meet WCAG 2.1 guidelines. We have three options:
Design Options
Feedback from the team is needed to finalize the focus state design.
Background on WCAG requirements (courtesy of @trallard)
- WCAG 2.1 SC 2.4.7
Proposed Design Options
Design Options
Here is a demo of these options in light and dark mode:
Light Mode
Dark Mode
My opinion:
For style, I prefer box over underline. Because links have an underline in general, I think adding just a thicker underline in focus states could be missed, and adding a full box would be a more visible change. So (1,3) > (2)
For colours, I think that the monochromatic colour scheme is better. I see some visual vibrations with the purple in dark mode, and I added that option to show how that would look, and I feel the monochrome version is more visually stable. So (1,2) > (3)
Overall, I would rank the options like this: 1 > 2 > 3
The text was updated successfully, but these errors were encountered: