Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide manylinux2014 wheels #493

Closed
vincentsarago opened this issue Jul 4, 2024 · 1 comment
Closed

provide manylinux2014 wheels #493

vincentsarago opened this issue Jul 4, 2024 · 1 comment
Labels

Comments

@vincentsarago
Copy link

👋 in version 2.10.1 the manylinux version was updated to use manylinux_2_28

numexpr/pyproject.toml

Lines 48 to 50 in 295f26b

# Let's use a more recent version of the manylinux image for more modern compilers
manylinux-x86_64-image = "manylinux_2_28"
manylinux-aarch64-image = "manylinux_2_28"

I totally understand this change but sadly this creates some issue for people who wants to build numexpr in AWS Lambda (because AWS Lambda python image are built on top of CentOS 7, as manylinux2014 image (https://github.com/pypa/manylinux?tab=readme-ov-file#manylinux2014-centos-7-based-glibc-217)

Note that manylinux_2_24 builds occur inside a Debian9 docker, where manylinux2010 and manylinux2014 builds occur inside a CentOS one. So for manylinux_2_24 the CIBW_BEFORE_ALL_LINUX command must use apt-get -y instead.

ref: https://cibuildwheel.pypa.io/en/stable/options/#examples_10

Note: Numpy still uses manylinux2014 https://github.com/numpy/numpy/blob/0acdad6c8b7808e0cc6ce19523e2150b3fb72b27/pyproject.toml#L149-L151

Copy link

github-actions bot commented Sep 3, 2024

Message to comment on stale issues. If none provided, will not mark issues stale

@github-actions github-actions bot added the Stale label Sep 3, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant