Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override float_to_top from the command line #1603

Closed
MarcoGorelli opened this issue Nov 26, 2020 · 2 comments
Closed

Override float_to_top from the command line #1603

MarcoGorelli opened this issue Nov 26, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone
5.7.0

Comments

@MarcoGorelli
Copy link
Contributor

It looks like it's not currently possible to override float_to_top from the command-line - would something like --float-to-top=0 be a welcome addition to `isort?

For a use-case, see here where someone has float_to_top set in their .isort.cfg file, but they want to override it when running isort on Jupyter Notebooks (via nbqa)
@timothycrosley timothycrosley added the enhancement New feature or request label Nov 29, 2020
@timothycrosley timothycrosley added this to the 5.7.0 milestone Nov 29, 2020
timothycrosley added a commit that referenced this issue Nov 29, 2020
@timothycrosley
Implemented #1603: Support for disabling float_to_top from the comman…
e9b1bd4 
…d line.
@timothycrosley
Copy link
Member

This is fixed in develop and will make it's way into the 5.7.0 release of isort

@MarcoGorelli
Copy link
Contributor Author

Awesome, thanks!

@MarcoGorelli MarcoGorelli mentioned this issue Dec 3, 2020
Closed
This was referenced Mar 14, 2021
Closed
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
5.7.0
Development

No branches or pull requests
2 participants
@timothycrosley @MarcoGorelli