Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptography 1.0 broke pypy builders #297

Closed
hynek opened this issue Aug 13, 2015 · 5 comments · Fixed by #298
Closed

cryptography 1.0 broke pypy builders #297

hynek opened this issue Aug 13, 2015 · 5 comments · Fixed by #298

Comments

@hynek
Copy link
Contributor

hynek commented Aug 13, 2015

Since the pypy on Travis’ infrastructure is 2.5 and bundles an old cffi, our pypy builders are failing now.

I’m not sure what to do but I’m tending to make pypy unsupported. cryptography itself does a huge dance with pyenv which I’m not willing to adapt. If others have the time, patches welcome. :-/ Until then we’re kind of stuck now.

@alex @reaperhulk

@or
Copy link

or commented Aug 14, 2015

I can confirm this for Python as well, I don't think it's pypy related.

A workaround is to pin cryptography==0.8.2 and to rebuild your virtualenv.
pyopenssl simply requires cryptography>0.7 and it probably needs to constrain it further to <=0.9 or something.

@reaperhulk
Copy link
Member

@or I'm not sure I understand. cryptography 1.0 should work fine with pyopenssl on environments that aren't pypy < 2.6. Do you have a reproducer?

@or
Copy link

or commented Aug 14, 2015

@reaperhulk You're right, I think my way to look at this was off. I guess pyopenssl isn't to blame at all, if it can work with those versions.

But in my case and in @hynek's case there's a dependency on an older cffi around and that breaks things. So since pyopenssl doesn't need a newer cryptography, pinning it to 0.8.2 works.

(At least it did for me, I'm not using pypy.)

@reaperhulk
Copy link
Member

Ah, yeah that will do it. You can pin to 0.9.3 until the older cffi dependency goes away (1.0 is the first release requiring cffi 1.1+). If you control the library that has the older cffi dep you can (likely) unpin it as well, as cffi 1.x supports the cffi 0.x APIs.

@reaperhulk
Copy link
Member

(Just for reference, the benefit of using cryptography 1.0 with pyopenssl is over 50x faster import times and ~20MB decrease in heap usage on import).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants