Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unstall condition incorrect when decelerating #958

Closed
laurensvalk opened this issue Feb 20, 2023 · 2 comments
Closed

[Bug] Unstall condition incorrect when decelerating #958

laurensvalk opened this issue Feb 20, 2023 · 2 comments
Labels
bug Something isn't working software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) topic: control Issues involving control system algorithms topic: motors Issues involving motors

Comments

@laurensvalk
Copy link
Member

Describe the bug
If the motor was unable to track a certain speed, it should not try to catch up when the reference speed is already decreasing.

But it is:

image

To reproduce

try:
    from pybricks.pupdevices import Motor
except ImportError:
    from pybricks.ev3devices import Motor
from pybricks.tools import wait
from pybricks.parameters import Port
from pybricks import version

print(version)

# Initialize the motor.
motor = Motor(Port.A)

# Allocate the data logs.
DURATION = 7000
motor.control.limits(speed=2000)
motor.log.start(DURATION)
motor.control.log.start(DURATION)

motor.run(2000)
wait(2000)
motor.run(100)
wait(2000)
motor.hold()
wait(2000)


# Transfer data logs.
print("Transferring data...")
motor.log.save("servo.txt")
motor.control.log.save("control.txt")
print("Done")

Originally posted by @laurensvalk in #956 (comment)

@laurensvalk laurensvalk added the triage Issues that have not been triaged yet label Feb 20, 2023
@laurensvalk
Copy link
Member Author

This is more generally an issue in drivebases. When driving fast and blocking one wheel, it takes a long time to catch up after release.

@laurensvalk laurensvalk added bug Something isn't working topic: motors Issues involving motors topic: control Issues involving control system algorithms and removed triage Issues that have not been triaged yet labels Feb 20, 2023
@dlech dlech added the software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) label Mar 7, 2023
@laurensvalk
Copy link
Member Author

I think we can leave this remaining issue as-is.

@laurensvalk laurensvalk closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) topic: control Issues involving control system algorithms topic: motors Issues involving motors
Projects
None yet
Development

No branches or pull requests

2 participants