Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update NXT/EV3 motor parameters #941

Closed
laurensvalk opened this issue Feb 6, 2023 · 2 comments
Closed

[Feature] Update NXT/EV3 motor parameters #941

laurensvalk opened this issue Feb 6, 2023 · 2 comments
Labels
topic: control Issues involving control system algorithms topic: motors Issues involving motors

Comments

@laurensvalk
Copy link
Member

We updated the motor control algorithms for Pybricks V3, but we did not yet update the control parameters for NXT/EV3 since we are not using them actively.

As a result, they may not work as expected at this time.

We'd need to try this out and update or tune the model parameters as needed.

Originally posted by @laurensvalk in #935 (comment)

@laurensvalk laurensvalk added topic: motors Issues involving motors topic: control Issues involving control system algorithms labels Feb 6, 2023
@winklerp
Copy link

winklerp commented Feb 16, 2023

 + 1

@laurensvalk
Copy link
Member Author

If #955 is fixed, it looks like comparatively little has to be changed for the parameters.

The main change to look into would be:

  • Whether to use the estimated or measured speed (EV3 can get speed fairly accurately)
  • Update the KD value, which currently still assumes using measured speed, but it is implemented with estimated speed; this value was never updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: control Issues involving control system algorithms topic: motors Issues involving motors
Projects
None yet
Development

No branches or pull requests

2 participants