Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Drop .left and .right attributes from DriveBase #910

Closed
laurensvalk opened this issue Jan 10, 2023 · 2 comments
Closed

[Feature] Drop .left and .right attributes from DriveBase #910

laurensvalk opened this issue Jan 10, 2023 · 2 comments
Labels
enhancement New feature or request software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) topic: motors Issues involving motors topic: optimization Issues related to optimizing the runtime for size or performance.

Comments

@laurensvalk
Copy link
Member

Is your feature request related to a problem? Please describe.
The DriveBase class has two undocumented attributes called left and right which can be used to access the motor objects with which the drive base was initialized.

Describe the solution you'd like
Delete them. They are not needed and not documented.

On Move Hub, this means we can drop the custom attribute handler for this class and save a bit more space.
@laurensvalk laurensvalk added enhancement New feature or request topic: motors Issues involving motors labels Jan 10, 2023
@laurensvalk
Copy link
Member Author

Maybe we can add an topic: optimization label for things like this.

@dlech dlech added software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) topic: optimization Issues related to optimizing the runtime for size or performance. labels Jan 10, 2023
@laurensvalk
Copy link
Member Author

Similar note: We can save 136 bytes by allowing just one DriveBase instance on Move Hub instead of 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) topic: motors Issues involving motors topic: optimization Issues related to optimizing the runtime for size or performance.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlech @laurensvalk