Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Simplify pbio color light interface #1798

Open
laurensvalk opened this issue Sep 2, 2024 · 0 comments
Open

[Feature] Simplify pbio color light interface #1798

laurensvalk opened this issue Sep 2, 2024 · 0 comments
Labels
enhancement New feature or request software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) topic: optimization Issues related to optimizing the runtime for size or performance.

Comments

@laurensvalk
Copy link
Member

This is a note for future consideration as we might not get to it now. The system light interface seems to have evolved to be a bit more complicated than it perhaps needs to be.

It seems to be currently:

user --> pbsys_instance.pbio_light --> pbsys callback --> pbio --> pbdrv

I suppose it could be:

user --> pbsys --> pbio --> pbdrv

The intermediate pbsys layer here would fulfill a similar role as in the current approach, to disallow user updates when a system light pattern is active.

Also, since the fading run animation is not really a system pattern but a (default) "user animation", it can perhaps also be taken out of pbsys, and just get initiated when the user color light is instantiated. This would also allow the user to .reset() the light to this state, which is currently not possible.

@laurensvalk laurensvalk added enhancement New feature or request triage Issues that have not been triaged yet topic: optimization Issues related to optimizing the runtime for size or performance. software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) and removed triage Issues that have not been triaged yet labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) topic: optimization Issues related to optimizing the runtime for size or performance.
Projects
None yet
Development

No branches or pull requests

1 participant