You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Provides better coverage for the challenges in optimisation a cost function for differing parameter types. A good example of this is add geometric parameters into our current fitting API (see #18):
This results in non-scalar geometric parameter when building the PyBaMM model. While we are capturing this issue in #18, adding a larger variety of fitting/optimisation tests will help us check potential edge-cases.
Motivation
No response
Possible implementation
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
Updating priority on this issue, a move towards diversifying our test suite would be very welcome. This can be done by updating the parameter identification tests we currently have, or by adding an additional test that iterates over a list of parameters to identify.
Feature description
Provides better coverage for the challenges in optimisation a cost function for differing parameter types. A good example of this is add geometric parameters into our current fitting API (see #18):
This results in non-scalar geometric parameter when building the PyBaMM model. While we are capturing this issue in #18, adding a larger variety of fitting/optimisation tests will help us check potential edge-cases.
Motivation
No response
Possible implementation
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: