Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Release v24.9.0 broken #494

Closed
BradyPlanden opened this issue Sep 11, 2024 · 2 comments · Fixed by #502
Closed

[Bug]: Release v24.9.0 broken #494

BradyPlanden opened this issue Sep 11, 2024 · 2 comments · Fixed by #502
Labels
bug Something isn't working

Comments

@BradyPlanden
Copy link
Member

BradyPlanden commented Sep 11, 2024

Python Version

3.12

Describe the bug

v24.9.0 is currently broken due to the optional pybamm[cite] dependency. The open issue on the PyBaMM repo is here.

We can either yank this release or release v24.9.1 with the optional dependency removed. This proceeds with a warning on import instead of an error. @NicolaCourtier @martinjrobins @brosaplanella @agriyakhetarpal Any preferences? I think patching to v24.9.1 is probably mine.

Steps to reproduce the behaviour

pip install pybop
import pybop

Relevant log output

No response

@BradyPlanden BradyPlanden added the bug Something isn't working label Sep 11, 2024
@agriyakhetarpal
Copy link
Member

Thanks for the ping, @BradyPlanden! Yanking the release sounds better to me, since PyBOP is unusable with PyBaMM v24.9.0 in this case. PyBOP v24.9.1 can be released afterwards when PyBaMM is ready.

@BradyPlanden
Copy link
Member Author

BradyPlanden commented Sep 11, 2024

Fair shout - I've yanked it.

@BradyPlanden BradyPlanden linked a pull request Sep 16, 2024 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants