Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geometric parameters list for echem models #350

Open
BradyPlanden opened this issue Jun 7, 2024 · 0 comments
Open

Update geometric parameters list for echem models #350

BradyPlanden opened this issue Jun 7, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers priority:medium

Comments

@BradyPlanden
Copy link
Member

Feature description

The current list of echem geometric parameters is not exhaustive and an update is required to ensure that we are capturing all parameters that require a model rebuild.

Here is the current list:

def set_geometric_parameters(self):

Motivation

Ensure we aren't missing parameters that require rebuild the underlying pybamm models.

Possible implementation

Iterate through the potential input parameters for the echem pybamm models and note any that provide a solver error related to geometric parameters: pybamm-team/PyBaMM#4107 and pybamm-team/PyBaMM#3649

Additional context

No response

@BradyPlanden BradyPlanden added enhancement New feature or request good first issue Good for newcomers labels Jun 7, 2024
@BradyPlanden BradyPlanden moved this to Todo in v24.9 Jul 18, 2024
@NicolaCourtier NicolaCourtier removed this from v24.9 Aug 28, 2024
@NicolaCourtier NicolaCourtier moved this to Todo in v24.12 Aug 28, 2024
@NicolaCourtier NicolaCourtier removed this from v24.12 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers priority:medium
Projects
None yet
Development

No branches or pull requests

1 participant