You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current list of echem geometric parameters is not exhaustive and an update is required to ensure that we are capturing all parameters that require a model rebuild.
Ensure we aren't missing parameters that require rebuild the underlying pybamm models.
Possible implementation
Iterate through the potential input parameters for the echem pybamm models and note any that provide a solver error related to geometric parameters: pybamm-team/PyBaMM#4107 and pybamm-team/PyBaMM#3649
Additional context
No response
The text was updated successfully, but these errors were encountered:
Feature description
The current list of echem geometric parameters is not exhaustive and an update is required to ensure that we are capturing all parameters that require a model rebuild.
Here is the current list:
PyBOP/pybop/models/lithium_ion/base_echem.py
Line 324 in fd171d0
Motivation
Ensure we aren't missing parameters that require rebuild the underlying pybamm models.
Possible implementation
Iterate through the potential
input
parameters for the echem pybamm models and note any that provide a solver error related to geometric parameters: pybamm-team/PyBaMM#4107 and pybamm-team/PyBaMM#3649Additional context
No response
The text was updated successfully, but these errors were encountered: