-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving cost function plotting? #235
Comments
Agreed, #198 changes the initial position from the red 'X' to a green circle, once #177 is merged we can update this with clearer annotations. At the same time as the above, the method should be updated for vectorised inputs in the Reference: https://docs.pybamm.org/en/latest/source/api/solvers/base_solver.html#pybamm.BaseSolver.solve |
Things to consider adding:
|
Feature description
The cost landscape plots are super cool! I think it would be nice to make some minor changes to how they work to improve understandability. It would help users to interpret these plots if it was easier to see certain aspects. For example, it's not very obvious at the moment where the initial guess and the final (optimised) points actually are. Could we make these clearer, e.g., by circling them or similar, and/or adding some annotation text?
Motivation
No response
Possible implementation
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: