Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving cost function plotting? #235

Closed
davidhowey opened this issue Mar 13, 2024 · 2 comments · Fixed by #570
Closed

Improving cost function plotting? #235

davidhowey opened this issue Mar 13, 2024 · 2 comments · Fixed by #570
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@davidhowey
Copy link
Member

Feature description

The cost landscape plots are super cool! I think it would be nice to make some minor changes to how they work to improve understandability. It would help users to interpret these plots if it was easier to see certain aspects. For example, it's not very obvious at the moment where the initial guess and the final (optimised) points actually are. Could we make these clearer, e.g., by circling them or similar, and/or adding some annotation text?

Motivation

No response

Possible implementation

No response

Additional context

No response

@davidhowey davidhowey added the enhancement New feature or request label Mar 13, 2024
@BradyPlanden
Copy link
Member

Agreed, #198 changes the initial position from the red 'X' to a green circle, once #177 is merged we can update this with clearer annotations.

At the same time as the above, the method should be updated for vectorised inputs in the model.simulate() call. As the casadi solver can accept vectorised input in the form of a dict, this should speed up the plotting time considerably.

Reference: https://docs.pybamm.org/en/latest/source/api/solvers/base_solver.html#pybamm.BaseSolver.solve

@BradyPlanden BradyPlanden moved this to Todo in v24.6 Mar 21, 2024
@BradyPlanden BradyPlanden added the good first issue Good for newcomers label Mar 21, 2024
@BradyPlanden BradyPlanden moved this to Todo in v24.9 Jun 30, 2024
@BradyPlanden
Copy link
Member

Things to consider adding:

@NicolaCourtier NicolaCourtier removed this from v24.6 Jul 5, 2024
@NicolaCourtier NicolaCourtier removed this from v24.9 Aug 28, 2024
@NicolaCourtier NicolaCourtier moved this to Todo in v24.12 Aug 28, 2024
@BradyPlanden BradyPlanden moved this from Todo to In Progress in v24.12 Nov 27, 2024
@BradyPlanden BradyPlanden self-assigned this Nov 27, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in v24.12 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants