-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial support for rules_python #64
Comments
Thanks @junyer! I was previously unsure about where to ask for help so I ended up with that workaround in my company internal repo. Very happy to see that pybind11_bazel is initiating support for rules_python, and please let me know if you need any testers. I will be here to help. |
I just wanted to drop a couple sketches of how I see this likely working. This is based on how Google makes pybind work internally, where the C++ integration is better with the Python rules. Fundamentally, what we want to to is define a The end result would look something like this...
I broke out separate
(except they use toolchain stuff to fill the values in). |
SGTM. Thanks! :D |
See bazelbuild/bazel#8674 (comment) for background.
For historical reasons, this logic enforces that
python_version
is"2"
,"3"
or""
. My current thinking is to extend that to permit"3.<minor>"
and"DEFAULT"
and "resolve" such versions toLabel
s viaINTERPRETER_LABELS
(andDEFAULT_PYTHON_VERSION
) as provided by@pythons_hub//:interpreters.bzl
.Ping (again), @rickeylev and @rwgk. :)
The text was updated successfully, but these errors were encountered: