Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework windows build/linkage #18

Open
kratman opened this issue Dec 30, 2024 · 3 comments
Open

Rework windows build/linkage #18

kratman opened this issue Dec 30, 2024 · 3 comments
Assignees
@kratman

Comments

@kratman
Copy link
Contributor

kratman commented Dec 30, 2024

The windows wheel build and delivery should be reworked to remove the usage of VCPKG.

Reference issue: pybamm-team/PyBaMM#3603
@kratman kratman self-assigned this Dec 30, 2024
@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented Dec 30, 2024 •
edited
Loading

The first part here is to use just one Vcpkg registry instead of two, but if we can remove both at the same time, so be it.

Switching to Meson might have been great here, which would have allowed us to use git submodules via Meson subprojects to do it.

@agriyakhetarpal
Copy link
Member

While we are at it, another thing to do with this is to switch to Clang instead of MSVC

@kratman
Copy link
Contributor Author

kratman commented Dec 30, 2024

Yeah I am re-working a bunch of the build stuff. I will take care of this one soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kratman kratman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kratman @agriyakhetarpal