Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Change of variable name for Measured battery open circuit potential #239

Closed
TomTranter opened this issue Mar 31, 2023 · 1 comment · Fixed by #240
Closed

[Bug]: Change of variable name for Measured battery open circuit potential #239

TomTranter opened this issue Mar 31, 2023 · 1 comment · Fixed by #240
Labels
bug Something isn't working

Comments

@TomTranter
Copy link
Collaborator

liionpack Version

0.3.3

Python Version

3.9

Describe the bug

Next release of PyBaMM will break Liionpack as referenced variable name is changed. There also appears to be some change in simulation results which needs looking into

Steps to Reproduce

No response

Expected behaviour

No response

Relevant log output

No response

Additional context

No response
@TomTranter TomTranter added the bug Something isn't working label Mar 31, 2023
@TomTranter TomTranter linked a pull request Mar 31, 2023 that will close this issue
Handle change in variable name for next PyBaMM release #240
Merged
@TomTranter
Copy link
Collaborator Author

Fixed in #240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle change in variable name for next PyBaMM release pybamm-team/liionpack
1 participant
@TomTranter