Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External variable and inputs getting mixed in causes input_parameter_order to fail[Bug]: #191

Closed
TomTranter opened this issue Sep 23, 2022 · 2 comments · Fixed by #192
Closed

External variable and inputs getting mixed in causes input_parameter_order to fail[Bug]: #191

TomTranter opened this issue Sep 23, 2022 · 2 comments · Fixed by #192
Assignees
@TomTranter
Labels
bug Something isn't working

Comments

@TomTranter
Copy link
Collaborator

liionpack Version

develop

Python Version

All

Describe the bug

The latest fix to the inputs fails when there is an external variable

Steps to Reproduce

No response

Expected behaviour

No response

Relevant log output

No response

Additional context

No response
@TomTranter TomTranter added the bug Something isn't working label Sep 23, 2022
@TomTranter TomTranter self-assigned this Sep 23, 2022
@valentinsulzer
Copy link
Member

Do you need help fixing? Is it a liionpack bug or pybamm?

@TomTranter
Copy link
Collaborator Author

It's liionpack - I think I've done it but it's more like a hack to the hack than a real solution.

@TomTranter TomTranter linked a pull request Sep 23, 2022 that will close this issue
This approach removes the external variables from the input_order list #192
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomTranter TomTranter

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

This approach removes the external variables from the input_order list pybamm-team/liionpack
2 participants
@TomTranter @valentinsulzer