Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate old ways of creating ParameterValues #2901

Closed
4 tasks
valentinsulzer opened this issue Apr 26, 2023 · 3 comments · Fixed by #2959
Closed
4 tasks

Deprecate old ways of creating ParameterValues #2901

valentinsulzer opened this issue Apr 26, 2023 · 3 comments · Fixed by #2959
Assignees
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows

Comments

@valentinsulzer
Copy link
Member

I think the transition to using python files or json file (BPX) for parameter values has gone fairly well so we can start to deprecate some of the old methods for importing values from csv files. These are no longer recommended but still possible from the codebase. We should also update the training videos on this very soon.

  • remove functionality to update from chemistry (old approach with separate files for anode/cathode/electrolyte etc)
  • remove functionality to load from csv
  • remove functionality to load a function from a string "[function]function_name"
  • remove functionality to load data from a string "[data]data_name"

Basically, users will be responsible for passing in a python dictionary where functions are python functions. Interpolants can be created as functions like this

This is a breaking change so let's discuss before committing

@brosaplanella
Copy link
Member

Shall we keep these options with a warning for a few releases and then remove?

@valentinsulzer
Copy link
Member Author

We've had this warning up for ~6 releases

@brosaplanella
Copy link
Member

Then happy to deprecate it :)

@valentinsulzer valentinsulzer added difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows labels May 8, 2023
@valentinsulzer valentinsulzer self-assigned this May 15, 2023
valentinsulzer added a commit that referenced this issue May 18, 2023
valentinsulzer added a commit that referenced this issue May 19, 2023
valentinsulzer added a commit that referenced this issue May 19, 2023
valentinsulzer added a commit that referenced this issue May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants