Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error or warning when one of the state variables gets too large #2138

Closed
valentinsulzer opened this issue Jun 30, 2022 · 4 comments · Fixed by #2139
Closed

Raise error or warning when one of the state variables gets too large #2138

valentinsulzer opened this issue Jun 30, 2022 · 4 comments · Fixed by #2139

Comments

@valentinsulzer
Copy link
Member

We should identify if a state variable gets too large (e.g. 1e10) as this indicates that either the model has been badly non-dimensionalized, or the model is wrong, or the parameters are wrong. This would give a clearer error message for cases like #2124
Should this be an error or warning? Maybe a logger error (doesn't cause the code to fail)?

@valentinsulzer valentinsulzer mentioned this issue Jul 1, 2022
8 tasks
@brosaplanella
Copy link
Member

Warning is probably best

@valentinsulzer
Copy link
Member Author

How about an error, but with a setting for the max allowed value that the user can change? I think it is quite serious if y gets that large, and should be treated as such, but with some flexibility to allow larger values by changing the setting.

@brosaplanella
Copy link
Member

That sounds reasonable. Are you thinking of a setting like defining the smoothness of max and similar functions? That would be useful I think.

@valentinsulzer
Copy link
Member Author

Yeah, see #2139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants