Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pytest-testmon plugin. #4720

Closed
prady0t opened this issue Dec 27, 2024 · 7 comments
Closed

Using pytest-testmon plugin. #4720

prady0t opened this issue Dec 27, 2024 · 7 comments
Assignees
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve

Comments

@prady0t
Copy link
Contributor

prady0t commented Dec 27, 2024

pytest-testmon is a very useful pytest plugin. It runs only those tests where the related changes have been done. It can be helpful as an option for local development and CI as it would be significantly faster (since we are running a lot lesser tests).

@prady0t
Copy link
Contributor Author

prady0t commented Dec 27, 2024

Originally suggested by @agriyakhetarpal

@prady0t prady0t added difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve labels Dec 27, 2024
@prady0t prady0t self-assigned this Dec 27, 2024
@prady0t prady0t changed the title Using pytest-testmon pluggin. Using pytest-testmon plugin. Dec 27, 2024
@kratman
Copy link
Contributor

kratman commented Dec 27, 2024

Something like that is fine for local dev, but we should test everything for CI. Dependencies can change, we have a complex codebase, and I am not sure anyone really looks at the periodic tests.

I don't think this is worth the effort to implement

@agriyakhetarpal
Copy link
Member

I agree with Eric. We would like to always test everything in CI, but please feel free to test it out over a few months on your fork and see how reliable it is.

In the meantime, documentation on how to set it up and run it so that someone can test the changes they've made in a local feature branch (maybe through a nox session or a positional argument to the tests session) would be helpful, such that it picks up the common ancestor between the default branch and said branch automatically.

@kratman
Copy link
Contributor

kratman commented Dec 27, 2024

I think the other thing is that tests don't take that long locally. Running the unit tests takes about a minute. We don't need to go overboard with infrastructure or documentation

@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented Dec 28, 2024

Yeah, fair point – the integration tests have usually passed for me in two minutes, and I expect this to be the same on modern computers running Windows and Linux as well. Unless @prady0t has something else to suggest, we could close this.

(P.S. I know I was the one to originally suggest it, but times have changed and pytest-testmon still remains experimental like it was back then).

@prady0t
Copy link
Contributor Author

prady0t commented Dec 28, 2024

Yes I guess it's not much needed then. This would have anyways made sense in local development but have never personally felt the need that much. Users already have an option to run selected tests via nox -s tests -- "path". I guess we should close this.

@prady0t prady0t closed this as completed Dec 28, 2024
@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented Dec 28, 2024

Closing as "not planned" for tracking this better down the line

@agriyakhetarpal agriyakhetarpal closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve
Projects
None yet
Development

No branches or pull requests

3 participants