-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using pytest-testmon
plugin.
#4720
Comments
Originally suggested by @agriyakhetarpal |
Something like that is fine for local dev, but we should test everything for CI. Dependencies can change, we have a complex codebase, and I am not sure anyone really looks at the periodic tests. I don't think this is worth the effort to implement |
I agree with Eric. We would like to always test everything in CI, but please feel free to test it out over a few months on your fork and see how reliable it is. In the meantime, documentation on how to set it up and run it so that someone can test the changes they've made in a local feature branch (maybe through a |
I think the other thing is that tests don't take that long locally. Running the unit tests takes about a minute. We don't need to go overboard with infrastructure or documentation |
Yeah, fair point – the integration tests have usually passed for me in two minutes, and I expect this to be the same on modern computers running Windows and Linux as well. Unless @prady0t has something else to suggest, we could close this. (P.S. I know I was the one to originally suggest it, but times have changed and |
Yes I guess it's not much needed then. This would have anyways made sense in local development but have never personally felt the need that much. Users already have an option to run selected tests via |
Closing as "not planned" for tracking this better down the line |
pytest-testmon is a very useful pytest plugin. It runs only those tests where the related changes have been done. It can be helpful as an option for local development and CI as it would be significantly faster (since we are running a lot lesser tests).
The text was updated successfully, but these errors were encountered: