Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable skipCI for all-contribs #4675

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Dec 13, 2024

Description

Makes all-contributors PRs run CI. This will allow us to have required checks and we can start to explicitly require tests to pass.

Fixes #4671

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman kratman merged commit 9cb4742 into pybamm-team:develop Dec 13, 2024
24 checks passed
@kratman kratman deleted the chore/fixBot branch December 13, 2024 18:51
@kratman
Copy link
Contributor Author

kratman commented Dec 13, 2024

@all-contributors please add @AndEsterson for infra

Copy link
Contributor

@kratman

I've put up a pull request to add @AndEsterson! 🎉

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (864388f) to head (1d8c72f).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4675   +/-   ##
========================================
  Coverage    99.21%   99.21%           
========================================
  Files          302      302           
  Lines        22880    22880           
========================================
  Hits         22701    22701           
  Misses         179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all-contributors bot so we can have required workflows
2 participants