[Bug]: Variables names missing from plot

[rtimms]

PyBaMM Version

24.11.1

Python Version

3.11

Describe the bug

Dynamic plot has no variable labels and shows the legend entries as t=0.00h for all plots

Steps to Reproduce

import pybamm

model = pybamm.lithium_ion.SPM()

sim = pybamm.Simulation(model)
sim.solve([0, 3600])


sim.plot()

Relevant log output

[rtimms]

From #4529

[kratman]

@rtimms Sorry missed in the review

[agriyakhetarpal]

cc: @medha-14, this might be worth a look!

[medha-14]

Ah, I must have missed this , will get to fixing this in a few days.

[brosaplanella]

Another issue that I believe is related: when plotting 2D variables the colourbar range is wrong.

Edit: digging a bit, I suspect the issue for the colourmaps is also to do with the plotting multiple times in the same plot. For 2D this should not be possible so the fix there only requires reverting that code to the previous version and throwing an error if multiple times are passed for a 2D variable.

24.9

24.11

[brosaplanella]

Digging a bit deeper, there also some inconsistencies when plotting multiple solutions in one plot. Given that there are multiple issues to fix (basically the issue is a lot harder than I anticipated in #4271 😅) and plotting is quite a major feature, I suggest reverting #4529 and making a minor release. We can then address this for the next major release.