Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow functions of time in experiment step #4187

Closed
valentinsulzer opened this issue Jun 17, 2024 · 0 comments · Fixed by #4222
Closed

Allow functions of time in experiment step #4187

valentinsulzer opened this issue Jun 17, 2024 · 0 comments · Fixed by #4222

Comments

@valentinsulzer
Copy link
Member

Users should be able to pass in arbitrary functions of time as the argument for a pybamm.step in an experiment, e.g.

def oscillating(t):
    return 1 + 0.1*np.sin(2*np.pi*t)

pybamm.step.current(oscillating, duration=3600)

Time should be taken to start at the beginning of the step, just like with drive cycles.

Note: this can be already be done using custom steps, but it requires writing a more complex step object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant